Introduce Connection::from_handle_owned #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It behaves almost the same as Connection::from_handle, but it promises to close the inner connection when the returned connection is closed or dropped. The rationale for having this function is that some users of Connection::from_handle obtain the handle simply by calling ffi::sqlite3_open_v2 or other similar function manually, and would still like for its resources to be released once the connection is dropped. The use-case behind this commit is from https://github.com/libsql/libsql/, where a new libsql_open call is introduced to pass other parameters (like virtual WAL interface) to the connection.
gwenn
added a commit
to gwenn/rusqlite
that referenced
this pull request
Dec 13, 2022
After merging PRs rusqlite#1263 and rusqlite#1248
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It behaves almost the same as Connection::from_handle, but it promises to close the inner connection when the returned connection is closed or dropped.
The rationale for having this function is that some users of Connection::from_handle obtain the handle simply by calling
ffi::sqlite3_open_v2or other similar function manually, and would still like for its resources to be released once the connection is dropped.The use-case behind this commit is from https://github.com/libsql/libsql/, where a new
libsql_openfunction is introduced to pass other parameters (like virtual WAL interface) to the connection.This commit comes with a simple test case loosely based on
test_from_handle.