Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i32 overflow in Connection::busy_timeout #604

Merged
merged 1 commit into from
Dec 29, 2019
Merged

Fix i32 overflow in Connection::busy_timeout #604

merged 1 commit into from
Dec 29, 2019

Conversation

arthurprs
Copy link
Contributor

@arthurprs arthurprs commented Dec 28, 2019 •
edited
Loading

Found after I tried using i32::max_value() as the timeout. Another possibility is to pass i32 max on overflow, that might be better in most cases.

@gwenn gwenn merged commit 54163a4 into rusqlite:master Dec 29, 2019
@gwenn
Copy link
Collaborator

gwenn commented Dec 29, 2019

Thanks.

@thomcc thomcc mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurprs @gwenn