-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for linking to winsqlite3 #796
Conversation
Signed-off-by: Nazar Mishturak <nazarmx@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
=======================================
Coverage 76.36% 76.36%
=======================================
Files 46 46
Lines 5294 5294
=======================================
Hits 4043 4043
Misses 1251 1251
Continue to review full report at Codecov.
|
Is there anything that should be done for our CI coverage here? |
@thomcc Maybe enabling builds with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Okay. I'll figure out CI in a follow up. @nazar554 Do you have any links where I can find out version info for versions shipped with win10? It's relevant probably to #706. I'm very surprised to hear they're shipping such an old version in windows, since SQLite tends not to break stuff with updates... P.S. Sorry for the delay with landing this. It came at a bad time for me personally. |
3.29 wouldn't be a problem to support. 3.8 and 3.12 are both newer than our current min version, although honestly I kind of want us to be able to say something like "we don't support SQLite versions older than 5 years" (in rusqlite — the pain caused by supporting these in libsqlite3-sys is pretty minor). Oh well, more food for thought I guess. |
There is system sqlite library on Windows 10 machines since Anniversary Update https://blogs.windows.com/windowsdeveloper/2017/02/06/using-sqlite-databases-uwp-apps/
Not sure if using
wrapper.h
is a good idea, otherwise I need to figure out full path to Windows SDK