Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linking to winsqlite3 #796

Merged
merged 1 commit into from
Oct 4, 2020
Merged

Add support for linking to winsqlite3 #796

merged 1 commit into from
Oct 4, 2020

Conversation

nazar554
Copy link
Contributor

@nazar554 nazar554 commented Aug 17, 2020

There is system sqlite library on Windows 10 machines since Anniversary Update https://blogs.windows.com/windowsdeveloper/2017/02/06/using-sqlite-databases-uwp-apps/

Not sure if using wrapper.h is a good idea, otherwise I need to figure out full path to Windows SDK

Signed-off-by: Nazar Mishturak <nazarmx@gmail.com>
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #796 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #796   +/-   ##
=======================================
  Coverage   76.36%   76.36%           
=======================================
  Files          46       46           
  Lines        5294     5294           
=======================================
  Hits         4043     4043           
  Misses       1251     1251           
Impacted Files Coverage Δ
libsqlite3-sys/build.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301a8d0...65644a6. Read the comment docs.

@thomcc
Copy link
Member

thomcc commented Oct 4, 2020

Is there anything that should be done for our CI coverage here?

@nazar554
Copy link
Contributor Author

nazar554 commented Oct 4, 2020

@thomcc Maybe enabling builds with winsqlite3 feature for Windows -msvc and -gnu targets? Not sure where to do that though

Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@thomcc
Copy link
Member

thomcc commented Oct 4, 2020

Okay. I'll figure out CI in a follow up.

@nazar554 Do you have any links where I can find out version info for versions shipped with win10? It's relevant probably to #706.

I'm very surprised to hear they're shipping such an old version in windows, since SQLite tends not to break stuff with updates...

P.S. Sorry for the delay with landing this. It came at a bad time for me personally.

@thomcc thomcc merged commit bc9b40a into rusqlite:master Oct 4, 2020
@nazar554
Copy link
Contributor Author

nazar554 commented Oct 4, 2020

@thomcc Here it was added (3.8.8.3, Windows 10 10.0.10586.0)

And then updated to 3.12.2 in Windows 10 10.0.14393.0

I am running 10.0.19041.508 (May 2020 update) right now and winsqlite3.dll is version 3.29.0.0

@thomcc
Copy link
Member

thomcc commented Oct 4, 2020

3.29 wouldn't be a problem to support. 3.8 and 3.12 are both newer than our current min version, although honestly I kind of want us to be able to say something like "we don't support SQLite versions older than 5 years" (in rusqlite — the pain caused by supporting these in libsqlite3-sys is pretty minor).

Oh well, more food for thought I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants