Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Relative file path not updating if folder name inside zip changes #479

Closed
1 task done
Exorcism0666 opened this issue Feb 20, 2024 · 3 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Exorcism0666
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

image

All logs: https://github.com/Exorcism0666/AutoPublish/actions/runs/7978627723/job/21784161875

@Exorcism0666 Exorcism0666 added bug Something isn't working help wanted Extra attention is needed labels Feb 20, 2024
@Exorcism0666
Copy link
Author

I think these are two different error messages, but I'm not sure.

@russellbanks
Copy link
Owner

The 2nd crash is fixed by da7e5e9. It's from a change I made today where SHA1's get removed from release notes. I use a fixed size string for this but didn't check for hashes greater than 40 characters, which meant it tried to add another character to the string when it's at its capacity.

@russellbanks
Copy link
Owner

The 1st crash was because Komac was trying to find the previous relative file path in the zip and couldn't find it because the folder name inside the zip had changed (Quaternion-0.0.95.1/quaternion.exe to Quaternion-0.0.96.1/quaternion.exe). I've changed it so that if this is the case, it will search for just quaternion.exe and then use the path to that exe as the new relative file path.

@russellbanks russellbanks changed the title [Bug]: called Option::unwrap() on a None value [Bug]: Relative file path not updating if folder name inside zip changes Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants