Parses simple blocks after a block group are silently ignored. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Matthias-Fauconneau What's the status of this PR? |
|
I think that's the proper solution. |
|
Could you please open an issue specifying what is left to do and close this PR? In this way I can remember what we need to implement :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple blocks after a block group are silently ignored.
Parsing into the existing simple_block would reorder.
This parses all simple blocks into struct BlockGroup to allow any interleaving of simple blocks or block groups inside a cluster while preserving the order.
If that's an acceptable solution, the serialization needs to be updated.