feat: allow AlignmentMode to be used on the command line #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nh13
commented
May 17, 2023
pmarks
reviewed
May 17, 2023
src/alignment.rs
Outdated
| @@ -38,20 +40,15 @@ pub enum AlignmentOperation { | |||
| /// | |||
| /// The default alignment mode is Global. | |||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | |||
| #[derive(Debug, PartialEq, Eq, Copy, Clone)] | |||
| #[derive(Default, Debug, PartialEq, Eq, Copy, Clone, ValueEnum)] | |||
There was a problem hiding this comment.
I think the ValueEnum derive needs to be conditional similar to Serialize?
nh13
commented
May 18, 2023
nh13
changed the title
Pull Request Test Coverage Report for Build 5021643648
💛 - Coveralls |
|
@pmarks thank-you for your patience as I come up to speed on rust! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.