Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmac: make `Midstate` type be something we can actually construct an engine from #43

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
2 participants
@apoelstra
Copy link
Member

commented May 2, 2019

No description provided.

src/hmac.rs Outdated
/// Pair of underlying hash midstates which represent the current state
/// of an `HmacEngine`
pub struct HmacMidState<T: Hash> {
inner: <T::Engine as HashEngine>::MidState,

This comment has been minimized.

Copy link
@stevenroose

stevenroose May 2, 2019

Collaborator

Why make them private? If so, I would at least have into_ methods. Either into_inner and into_outer or either into_inner_outer() -> (inner, outer) or something. But I think it's easier to just have the fields public.

This comment has been minimized.

Copy link
@apoelstra

apoelstra May 2, 2019

Author Member

Sure, I'll just make them public

This comment has been minimized.

Copy link
@stevenroose

stevenroose May 2, 2019

Collaborator

Also public midstate fields makes it easier to construct static midstate objects.

@apoelstra apoelstra force-pushed the 2019-05-hmac-engine branch from 63201d0 to f14f4b1 May 2, 2019

@apoelstra apoelstra merged commit 5a80597 into master May 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.