This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
hmac: make Midstate type be something we can actually construct an engine from
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenroose
reviewed
May 2, 2019
src/hmac.rs
Outdated
| /// Pair of underlying hash midstates which represent the current state | ||
| /// of an `HmacEngine` | ||
| pub struct HmacMidState<T: Hash> { | ||
| inner: <T::Engine as HashEngine>::MidState, |
There was a problem hiding this comment.
Why make them private? If so, I would at least have into_ methods. Either into_inner and into_outer or either into_inner_outer() -> (inner, outer) or something. But I think it's easier to just have the fields public.
There was a problem hiding this comment.
Sure, I'll just make them public
There was a problem hiding this comment.
Also public midstate fields makes it easier to construct static midstate objects.
apoelstra
force-pushed
the
2019-05-hmac-engine
branch
from
63201d0
to
f14f4b1
Compare
stevenroose
approved these changes
May 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.