Improve error display for invalid witness version #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Arguably |
apoelstra
approved these changes
Jan 8, 2024
yes, good point, will respin. |
`Display` imlps often include long lines but the code is simple and having it split over 4 lines is a waist of vertical space.
We have two errors that cover invalid witness version, for one we print the field element which can be confusing for some values and for the other we omit the invalid version all together - we can do better. Print the field element as well as the integer value when displaying the two invalid witness version errors. Fix: rust-bitcoin#162
tcharding
force-pushed
the
01-08-print-witness-as-int
branch
from
d9bb03e
to
e988f34
Compare
|
Added patch up front to skip rustfmt, then used 'bech32 character' as suggested. |
apoelstra
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two errors that cover invalid witness version, for one we print the field element which can be confusing for some values and for the other we omit the invalid version all together - we can do better.
Print the field element as well as the integer value when displaying the two invalid witness version errors.
Fix: #162