Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error display for invalid witness version #165

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Improve error display for invalid witness version #165

merged 2 commits into from
Jan 9, 2024

Commits on Jan 9, 2024

  1. Add rustfmt::skip to Display impl 

    `Display` imlps often include long lines but the code is simple and
having it split over 4 lines is a waist of vertical space.
    @tcharding
    tcharding committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d692972 View commit details
    Browse the repository at this point in the history

  2. Improve error display for invalid witness version 

    We have two errors that cover invalid witness version, for one we print
the field element which can be confusing for some values and for the
other we omit the invalid version all together - we can do better.

Print the field element as well as the integer value when displaying the
two invalid witness version errors.

Fix: rust-bitcoin#162
    @tcharding
    tcharding committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    e988f34 View commit details
    Browse the repository at this point in the history