-
Notifications
You must be signed in to change notification settings - Fork 658
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #718: Converting LeafVersion into an enum
ef8a3a8 Introduce FutureLeafVersion (Dr Maxim Orlovsky) b028385 Improve docs in LeafVersion (Dr Maxim Orlovsky) 839c022 Make serde for LeafVersion to have byte representation (Dr Maxim Orlovsky) 67b8db0 Converting LeafVersion into an enum (Dr Maxim Orlovsky) 2405417 Use TAPROOT_ANNEX_PREFIX in sighash module (Dr Maxim Orlovsky) Pull request description: The original `LeafVersion` implementation was just a newtype around `u8`. I think that having enum explicitly listing consensus script implementation rules may be more beneficial in terms of both code readibility and future use of multiple script types, where `LeafVersion` may operate as a context object provided to `Script` to specify interpretation rules for particular op codes. ACKs for top commit: Kixunil: ACK ef8a3a8 sanket1729: crACK ef8a3a8. Waiting a day to let others complete review before merging. apoelstra: ACK ef8a3a8 Tree-SHA512: 3356d2b9b00cf904edfece26d26ffbc646ba74446cc23ec4b2b4026ed50861285802f077226e30ba8fed466f68f8e8556c729ce48cb38581b1d95a02a6fde9cf
- Loading branch information
Showing
3 changed files
with
119 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters