Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompactTarget is missing LowerHex and UpperHex impls #2219

Closed
Kixunil opened this issue Nov 23, 2023 · 4 comments · Fixed by #2221
Closed

CompactTarget is missing LowerHex and UpperHex impls #2219

Kixunil opened this issue Nov 23, 2023 · 4 comments · Fixed by #2221
Labels
API hole Important API missing - significantly degrades usability or idiomatic usage enhancement good first issue minor API Change This PR should get a minor version bump

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Nov 23, 2023

These are useful and used in the wild.
@Kixunil Kixunil added enhancement minor API Change This PR should get a minor version bump good first issue API hole Important API missing - significantly degrades usability or idiomatic usage labels Nov 23, 2023
@crywolf
Copy link
Contributor

crywolf commented Nov 25, 2023

Hi @Kixunil ,
I have implemented these traits for CompactTarget, but pre-commit githook does not allow me to commit the file I changed, because cargo +nightly fmt --check yells at me about some formatting issues in completely unrelated file I have not touched: rust-bitcoin/io/src/lib.rs.

I've changed only rust-bitcoin/bitcoin/src/pow.rs which has no formatting issues.

How to solve it? Should I just skip the hook?

@apoelstra
Copy link
Member

@crywolf yeah, just skip the hook.

@tcharding I guess we should remove that from the githooks? Are they installed automatically somehow or do people need to manually remove the hooks now that we're not forcing the library to be formatted every day?

@crywolf crywolf mentioned this issue Nov 25, 2023
Merged
@crywolf
Copy link
Contributor

crywolf commented Nov 25, 2023

I've skipped the hook.
They are not installed automatically, I just followed README and installed it manually before. Deleting the last line in that hook should be enough.

@crywolf crywolf mentioned this issue Nov 25, 2023
Merged
@crywolf
Copy link
Contributor

crywolf commented Nov 25, 2023

I deleted that rustfmt check from githook here #2222 so it should work for everybody now

apoelstra added a commit that referenced this issue Nov 26, 2023
@apoelstra
Merge #2222: Remove nightly rustfmt check from pre-commit githook
65050db 
5a3f1a6 Remove nightly rustfmt check from pre-commit githook  See #2135 (Vojtěch Toman)

Pull request description:

  See #2135 and discussion [#2219#issuecomment-1826437013](#2219 (comment))

ACKs for top commit:
  Kixunil:
    ACK 5a3f1a6
  apoelstra:
    ACK 5a3f1a6

Tree-SHA512: 3fabadcbc4f80fb133318138aad8e1baccbeffad57d09fe86ed12f1156e8c9505911f8fc3a785896832fad02e20a366e9d95d37602bdd5fc02d9c715a867cb72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API hole Important API missing - significantly degrades usability or idiomatic usage enhancement good first issue minor API Change This PR should get a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement LowerHex and UpperHex for CompactTarget crywolf/rust-bitcoin
3 participants
@crywolf @Kixunil @apoelstra