Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LowerHex and UpperHex for CompactTarget #2221

Merged
merged 1 commit into from Nov 26, 2023
Merged

Implement LowerHex and UpperHex for CompactTarget #2221

merged 1 commit into from Nov 26, 2023

Conversation

crywolf
Copy link
Contributor

@crywolf crywolf commented Nov 25, 2023

closes #2219

Kixunil
Kixunil approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 58710df

@Kixunil
Copy link
Collaborator

Kixunil commented Nov 26, 2023

Good PR, thanks!

apoelstra
apoelstra approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 58710df

@apoelstra apoelstra merged commit cfa6768 into rust-bitcoin:master Nov 26, 2023
29 checks passed
@crywolf crywolf deleted the compact_target_hex_fmt branch November 26, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CompactTarget is missing LowerHex and UpperHex impls
3 participants
@crywolf @Kixunil @apoelstra