Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking PR - v0.30.0 #1699

Merged
merged 1 commit into from Mar 22, 2023

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Mar 7, 2023

@tcharding tcharding changed the title Release tracking PR - v0.29.0 Release tracking PR - v0.30.0 Mar 7, 2023
@tcharding tcharding mentioned this pull request Mar 7, 2023
@tcharding
Copy link
Member Author

Force pushed some more changelog notes re updating dependencies we control.

@Kixunil Kixunil added the Optech Make Me Famous! Look! Look! Look! COOL NEW FEATURE! label Mar 18, 2023
@Kixunil
Copy link
Collaborator

Kixunil commented Mar 18, 2023

Note for Optech: should be published after this is merged and the crate is out. Should be soon.

@apoelstra
Copy link
Member

@tcharding would you be willing to open a PR to do the actual update?

@apoelstra
Copy link
Member

Oh, never mind, this is the PR -- except we just need a PR to update the rust-secp dep. I can do that.

@apoelstra
Copy link
Member

Done: #1714

@tcharding
Copy link
Member Author

Are we happy with the taproot API improvements under the "API improvements" header and not in their own section? (Mentioning because we just added a separate taproot section to the blog post.)

@tcharding
Copy link
Member Author

@apoelstra I've set the date to Sunday the 19th March so if we release in the next day or two the "set date" checkbox in PR description can be considered done.

@tcharding tcharding force-pushed the 03-07-changelog branch 2 times, most recently from 6d568c1 to f7a4324 Compare March 19, 2023 01:25
bitcoin/CHANGELOG.md Outdated Show resolved Hide resolved
bitcoin/CHANGELOG.md Show resolved Hide resolved
@Kixunil
Copy link
Collaborator

Kixunil commented Mar 19, 2023

Are we happy with the taproot API improvements under the "API improvements" header and not in their own section? (Mentioning because we just added a separate taproot section to the blog post.)

If you mean in changelog then yes, they don't have to be the same.

@Kixunil Kixunil added this to the 0.30.0 milestone Mar 19, 2023
@tcharding
Copy link
Member Author

Force push is just the mentions of ScriptBuf.

@tcharding
Copy link
Member Author

Rebased on master and added initial link to the new website. Used direct link to blogpost. We have a chicken and egg problem with the blog post and changelog now, we (I) want to add links to online docs to the blog post which implies code released (changelog notes released) which link to the blogpost.

@Kixunil
Copy link
Collaborator

Kixunil commented Mar 19, 2023

IMO start by releasing blog first because less people will accidentally stumble upon it.

@tcharding
Copy link
Member Author

Aight, I rekon we are good to pull the trigger then - either @apoelstra to do it (blogpost and crate release) or I can be online to do it with you Andrew at normal time. I'm getting pretty excited about this release FTR.

@tcharding
Copy link
Member Author

Bother, too excited it would seem. We still need to merge #1714 and then rebase this one.

@apoelstra
Copy link
Member

@tcharding #1714 is merged. We are good to go here.

@tcharding tcharding force-pushed the 03-07-changelog branch 2 times, most recently from 99d8169 to 31f0f83 Compare March 20, 2023 21:26
@tcharding
Copy link
Member Author

Updated the release date in changelog to 21st

apoelstra
apoelstra previously approved these changes Mar 20, 2023
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 99d8169

@tcharding
Copy link
Member Author

Needs an ack from you @Kixunil!

@tcharding
Copy link
Member Author

Perhaps give @sanket1729 a chance to ack as well?

Add changelog notes and bump the version number to v0.30.0.
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reACK ffee8ad

@tcharding
Copy link
Member Author

reack please @sanket1729 and @Kixunil if you are still about - I rekon we can still get this out today!

Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ffee8ad

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ffee8ad

@tcharding
Copy link
Member Author

Wo ho ho, getting close ...

@apoelstra
Copy link
Member

Just started merge process. should be less than 30 minutes.

@tcharding
Copy link
Member Author

tcharding commented Mar 22, 2023

Can you merge the blog post PR now then? I can deploy if you like (if I do it then I can fix it if its not working :)

@tcharding
Copy link
Member Author

tcharding commented Mar 22, 2023

In order for the blog post to be live when we release I'm going to deploy it now.

EDIT: Oh I misread "merge process" as "release process", is there another step before you publish to crates.io? I have not deployed the site yet.

@apoelstra
Copy link
Member

@tcharding yes, the remaining thing to do is merge this PR :). But I have to run my CI job on the merge commit before I can do that.

@apoelstra apoelstra merged commit d65646c into rust-bitcoin:master Mar 22, 2023
22 checks passed
@sanket1729
Copy link
Member

Let's go!!!

@apoelstra
Copy link
Member

@sanket1729 sorry, we have one more thing to fix :) the readme key in Cargo.toml needs us to add a ../ because we moved the workspace.

Tobin will PR, then if we can quickl ACK (I won't bother doing any tests) we should be able to push in a few minutes.

@tcharding
Copy link
Member Author

#1723

@apoelstra
Copy link
Member

And we're live!

@sanket1729
Copy link
Member

Is the website also up? I would like tweet about the release.

@tcharding
Copy link
Member Author

I've borked the website, trying to fix now ...

@sanket1729
Copy link
Member

Wohoo. Seems to be up now https://rust-bitcoin.github.io/blog/release-0.30.0/

@apoelstra
Copy link
Member

Looks like a 404 to me

@tcharding
Copy link
Member Author

yeah I have no idea why. I've hard reset to same commit as was up before and settings in https://github.com/rust-bitcoin/rust-bitcoin.github.io/settings/pages look correct

@tcharding
Copy link
Member Author

Looks like its stuck in githubs github pages build system

@tcharding
Copy link
Member Author

Its through their build system now but 404 still

@tcharding
Copy link
Member Author

It was up the whole time, cache on my machine was returning the 404

@tcharding
Copy link
Member Author

face palm, still 404 - this is working: https://rust-bitcoin.github.io/index.html

@tcharding
Copy link
Member Author

tcharding commented Mar 22, 2023

We are live yo! https://rust-bitcoin.org/blog

@tcharding tcharding deleted the 03-07-changelog branch March 22, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optech Make Me Famous! Look! Look! Look! COOL NEW FEATURE!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants