New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tracking PR - v0.30.0 #1699
Conversation
e03bc6f
to
0a72ddc
Compare
Force pushed some more changelog notes re updating dependencies we control. |
Note for Optech: should be published after this is merged and the crate is out. Should be soon. |
@tcharding would you be willing to open a PR to do the actual update? |
Oh, never mind, this is the PR -- except we just need a PR to update the rust-secp dep. I can do that. |
Done: #1714 |
Are we happy with the taproot API improvements under the "API improvements" header and not in their own section? (Mentioning because we just added a separate taproot section to the blog post.) |
@apoelstra I've set the date to Sunday the 19th March so if we release in the next day or two the "set date" checkbox in PR description can be considered done. |
6d568c1
to
f7a4324
Compare
If you mean in changelog then yes, they don't have to be the same. |
f7a4324
to
ee73905
Compare
Force push is just the mentions of |
ee73905
to
f49e046
Compare
Rebased on master and added initial link to the new website. Used direct link to blogpost. We have a chicken and egg problem with the blog post and changelog now, we (I) want to add links to online docs to the blog post which implies code released (changelog notes released) which link to the blogpost. |
IMO start by releasing blog first because less people will accidentally stumble upon it. |
Aight, I rekon we are good to pull the trigger then - either @apoelstra to do it (blogpost and crate release) or I can be online to do it with you Andrew at normal time. I'm getting pretty excited about this release FTR. |
Bother, too excited it would seem. We still need to merge #1714 and then rebase this one. |
@tcharding #1714 is merged. We are good to go here. |
99d8169
to
31f0f83
Compare
Updated the release date in changelog to 21st |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 99d8169
Needs an ack from you @Kixunil! |
Perhaps give @sanket1729 a chance to ack as well? |
Add changelog notes and bump the version number to v0.30.0.
ffee8ad
31f0f83
to
ffee8ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reACK ffee8ad
reack please @sanket1729 and @Kixunil if you are still about - I rekon we can still get this out today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ffee8ad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ffee8ad
Wo ho ho, getting close ... |
Just started merge process. should be less than 30 minutes. |
Can you merge the blog post PR now then? I can deploy if you like (if I do it then I can fix it if its not working :) |
In order for the blog post to be live when we release I'm going to deploy it now. EDIT: Oh I misread "merge process" as "release process", is there another step before you publish to crates.io? I have not deployed the site yet. |
@tcharding yes, the remaining thing to do is merge this PR :). But I have to run my CI job on the merge commit before I can do that. |
Let's go!!! |
@sanket1729 sorry, we have one more thing to fix :) the Tobin will PR, then if we can quickl ACK (I won't bother doing any tests) we should be able to push in a few minutes. |
And we're live! |
Is the website also up? I would like tweet about the release. |
I've borked the website, trying to fix now ... |
Wohoo. Seems to be up now https://rust-bitcoin.github.io/blog/release-0.30.0/ |
Looks like a 404 to me |
yeah I have no idea why. I've hard reset to same commit as was up before and settings in https://github.com/rust-bitcoin/rust-bitcoin.github.io/settings/pages look correct |
Looks like its stuck in githubs github pages build system |
Its through their build system now but 404 still |
It was up the whole time, cache on my machine was returning the 404 |
face palm, still 404 - this is working: https://rust-bitcoin.github.io/index.html |
We are live yo! https://rust-bitcoin.org/blog |
Add changelog notes and bump the version number to v0.30.0.
TODO - pre-merge
bitcoin_hashes
0.12: release bitcoin_hashes 0.12 #1694secp256k1
dependency to use newly released v0.27: update rust-secp to 0.27.0 #1714Removeschemars
pin from manifest #1696const
context #1710Work::log2
implementation forU256::to_f64
#1713Denomination
asnon_exhaustive
#1721TODO - post release