Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing section #1719

Merged
merged 1 commit into from Mar 21, 2023
Merged

Update testing section #1719

merged 1 commit into from Mar 21, 2023

Conversation

tcharding
Copy link
Member

The testing section in CONTRIBUTING.md is stale, update it to point readers towards the readme.

@tcharding
Update testing section
fe83ee6 
The testing section in `CONTRIBUTING.md` is stale, update it to point
readers towards the readme.
@apoelstra
Copy link
Member

This probably doesn't need to be a draft either; doesn't really have anything to do with release and won't cause conflicts.

apoelstra
apoelstra approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fe83ee6

Kixunil
Kixunil approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fe83ee6

@Kixunil Kixunil added trivial Obvious, easy and quick to review (few lines or doc-only...) documentation labels Mar 21, 2023
@tcharding tcharding marked this pull request as ready for review March 21, 2023 20:28
@tcharding tcharding marked this pull request as draft March 21, 2023 20:29
@tcharding
Copy link
Member Author

tcharding commented Mar 21, 2023 •
edited

Leaving as draft, I don't want any of my PRs merged because I don't want to have to rebase #1699 and hold up the release. Wooops I momentarily forgot how git works, no conflicts means no need to rebase - face palm.

@tcharding tcharding marked this pull request as ready for review March 21, 2023 21:14
@tcharding tcharding mentioned this pull request Mar 21, 2023
Merged
8 tasks
@apoelstra apoelstra merged commit 4b405b2 into rust-bitcoin:master Mar 21, 2023
22 checks passed
apoelstra added a commit that referenced this pull request Mar 22, 2023
@apoelstra
Merge #1699: Release tracking PR - v0.30.0
d65646c 
ffee8ad Bump version to v0.30.0 (Tobin C. Harding)

Pull request description:

  Add changelog notes and bump the version number to v0.30.0.

  ## TODO - pre-merge

  - [x] Release `bitcoin_hashes` 0.12: #1694
  - [x] Release secp 0.27: rust-bitcoin/rust-secp256k1#588
    - rust-bitcoin/rust-secp256k1#590
  - [x] Update `secp256k1` dependency to use newly released v0.27: #1714
  - [x] Merge
    - ~#1696
    - #1695
    -  #1111
  - [x] If time permits merge these:
    - #1710
    - #1705
    - #1713
  - [x] Set the release date in changelog header
  - [x] And merge these:
    - #1721
    - #1720
    - #1719
    - #1717

  ## TODO  - post release
  - [ ] Release the blogpost: rust-bitcoin/www.rust-bitcoin.org#2
     - ~Set the date in the blog post to match the date 0.30 is released~

ACKs for top commit:
  sanket1729:
    reACK ffee8ad
  Kixunil:
    ACK ffee8ad
  apoelstra:
    ACK ffee8ad

Tree-SHA512: b0ea113ee1726fd9b263d0e01fe14bd544c007c05a9ac43b6c2d4edbeef3bb3ad456b061ef086626e1e1b27a0cda49cb6bc28aac3ad1691d72ffe00400ed5b45
@tcharding tcharding deleted the 03-21-contributing branch March 22, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tcharding @apoelstra @Kixunil