Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BlockHeader::spv_validate to validate_pow #273

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Rename BlockHeader::spv_validate to validate_pow #273

merged 1 commit into from
Jun 7, 2019

Conversation

stevenroose
Copy link
Collaborator

Fixes #182.

@stevenroose stevenroose added the API break This PR requires a version bump for the next release label Jun 6, 2019
apoelstra
apoelstra approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me.

jonasnick
jonasnick reviewed Jun 7, 2019
View reviewed changes
Copy link
Contributor

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two Errors SpvBadTarget and SpvBadProofOfWork could be renamed too. They are only returned in this function.

@TheBlueMatt TheBlueMatt merged commit 860e74e into rust-bitcoin:master Jun 7, 2019
@petertodd
Copy link
Contributor

Thanks!

yancyribbens pushed a commit to yancyribbens/rust-bitcoin that referenced this pull request Mar 23, 2024
@sanket1729
Merge rust-bitcoin/rust-miniscript#410: Implement source for error …
c1bba6f 
…types

5935d86 Implement error::Error for all error types (Tobin C. Harding)
a5db0f0 Re-order error code blocks (Tobin C. Harding)
2eac9de Remove error::Error::description (Tobin C. Harding)
3bdeb8c Move SigType down the file (Tobin C. Harding)

Pull request description:

  Now we have MSRV of 1.41.1 we can implement `source` for improved error handling.

  Patches 1-3 are preparatory cleanup, patch 4 adds all the `source` impls.

  Resolves: rust-bitcoin#273

ACKs for top commit:
  apoelstra:
    ACK 5935d86
  sanket1729:
    ACK 5935d86. Checked that all changes correctly pass through the source. Did not check whether there are more Error types that are not covered.

Tree-SHA512: f74f0bfabba92dab6e88d26ec098a60c66eae8cbbad34433ef0f95c42d1d79352d1a408506e604b5564c0e4b15ed3a7e41ffe1d2fd1ba127b66bdba287091357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasnick jonasnick jonasnick left review comments

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
API break This PR requires a version bump for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blockheader::spv_validate() is misleadingly named
5 participants
@stevenroose @petertodd @TheBlueMatt @apoelstra @jonasnick