Implement source for error types
#410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't guarantee I didn't miss any, I used |
|
Face palm, I did this same work in
My OCD cannot handle that so I'll fix them both tomorrow, sending this to draft. Please comment if you have an opinion on these otherwise I'll arbitrarily pick and do them all the same. |
|
No opinion :). |
Put the `SigType` enum below where it is first used instead of in the middle of the error types/impls.
The `description` method is deprecated since Rust 1.33.0, now we are on MSRV of 1.41.1 we can remove it in favour of `Display`.
Audit the whole codebase and re-order code around error handling so that it is all in a uniform layout in the file, specifically 1. Error declaration 2. impl Display ... 3. impl error::Error ... 4. All the From impls Refactor only, no logic changes. All changes are just moving blocks of code around.
tcharding
force-pushed
the
05-17-error-source
branch
from
013922c
to
3e5ef23
Compare
Now that we have an MSRV of 1.41.1 we can implement `std::Error` by way of the `cause` method. Audit the whole codebase and implement `cause` for all error types, matching explicitly on enum variants so we don't forget to update the impls if/when the error enums get modified.
tcharding
force-pushed
the
05-17-error-source
branch
from
3e5ef23
to
5935d86
Compare
apoelstra
approved these changes
May 21, 2022
sanket1729
approved these changes
May 26, 2022
There was a problem hiding this comment.
ACK 5935d86. Checked that all changes correctly pass through the source. Did not check whether there are more Error types that are not covered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have MSRV of 1.41.1 we can implement
sourcefor improved error handling.Patches 1-3 are preparatory cleanup, patch 4 adds all the
sourceimpls.Resolves: #273