Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to secp256k1 0.13 #278

Closed
wants to merge 1 commit into from
Closed

Update to secp256k1 0.13 #278

wants to merge 1 commit into from

Conversation

jonasnick
Copy link
Contributor

No description provided.

@apoelstra
Copy link
Member

blocked until we have released other breaking changes

@jonasnick jonasnick closed this Jun 10, 2019
@jonasnick jonasnick reopened this Jun 10, 2019
@jonasnick jonasnick closed this Jun 10, 2019
@jonasnick jonasnick reopened this Jun 10, 2019
@jonasnick
Copy link
Contributor Author

The travis rust 1.22 build always times out. Works locally on my machine...

@stevenroose
Copy link
Collaborator

Hmm... Our Elements Travis tests also time out when compiling secp256k1-zkp. Could that be related?

@jonasnick jonasnick mentioned this pull request Jun 26, 2019
Merged
@jonasnick
Copy link
Contributor Author

It turns out I was not able to reproduce this problem because I used a Cargo.lock that was created with a newer rustc.
If I start with a fresh clone of the repo I can reproduce the infinite loop.

This is a bug in cargo 0.23.0.
rust-bitcoinconsensus 0.16.4 (the latest) is not compatible with this PR because cc is pinned to =1.0.26.
Newer rust versions are able to just use rust-bitcoinconsensus 0.16.3.
My hypothesis is that if we release a new version of rust-bitcoinconsus that is compatible we won't run into the infinite loop, but I don't see a way to test that locally.
I've opened PR rust-bitcoin/rust-bitcoinconsensus#9 in rust-bitcoinconsensus which will hopefully resolve this problem once released.

@elichai elichai mentioned this pull request Jul 19, 2019
Closed
@jonasnick
Copy link
Contributor Author

Superseded by #298

@jonasnick jonasnick closed this Jul 27, 2019
yancyribbens pushed a commit to yancyribbens/rust-bitcoin that referenced this pull request Mar 23, 2024
@sanket1729
Merge rust-bitcoin/rust-miniscript#291: Taproot Compiler
7efe5e0 
2b13694 Add non-trivial multi-node example (Aman Rojjha)
1c2a80e Add validity and malleability checks. (Aman Rojjha)
0866807 Add P2Tr compiler (Aman Rojjha)
285207e Internal-key extraction done (Aman Rojjha)
26fc574 Policy to single-leaf TapTree compilation done (Aman Rojjha)

Pull request description:

  This PR builds on top of rust-bitcoin#278.

  This is one in a series of PRs aimed to implement a feature-complete *Pay-to-Taproot* **P2Tr** compiler.
  Specifically, this introduces a basic compilation for a given policy by collecting the leaf nodes of the *tree* generated by considering root-level disjunctive `OR`and using this to generate a `TapTree`.

  > Assuming that _duplicate keys_ are **NOT** possible even in different branches of the TapTree.

  # Follow Up PRs

  - rust-bitcoin#342  - Uses heuristic for tree-generation/ _merging_ algorithm while buillding `TapTree` to optimize over the *expected average total cost*.
  - rust-bitcoin#352
  - A future PR implementing enumerative strategies for optimizing `thresh` `k`-of-`n` and similar structures.

ACKs for top commit:
  apoelstra:
    ACK 2b13694
  sanket1729:
    ACK 2b13694 . Let's push forward on this. In the interest of ACKs and multiple rebases already done here, I am merging this. We recently shifted to rust 2018. And this code has a bunch of warnings because of it.

Tree-SHA512: 4ceca51a383f5d52b572a16937bbcc3a9c53f0247e4b6df57a6547fd0b1c7cc33ff04dd9a476914bcf6d0a09e255918b8f7ebfe176c839d6ae31c84613dce67f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonasnick @apoelstra @stevenroose