Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bitcoin dependency #234

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Aug 8, 2022

This update breaks MSRV 1.29 so cannot be merged until we merge: #222

Upgrade rust-bitcoin dependency to the newly released version (0.29.0). Includes fixing newly deprecated APIs.

  • Patch one does the upgrade
  • Patch two bumps the crate version and adds release notes

@dpc
Copy link
Collaborator

dpc commented Aug 16, 2022

++ cargo generate-lockfile --verbose
    Updating registry `[https://github.com/rust-lang/crates.io-index`](https://github.com/rust-lang/crates.io-index%60)
error: no matching package named `actual-serde` found
location searched: registry `https://github.com/rust-lang/crates.io-index`
required by package `bitcoin v0.29.0`
    ... which is depended on by `bitcoincore-rpc-json v0.[16](https://github.com/rust-bitcoin/rust-bitcoincore-rpc/runs/7736593860?check_suite_focus=true#step:4:17).0 (file:///home/runner/work/rust-bitcoincore-rpc/rust-bitcoincore-rpc/json)`

Actual serde?

@tcharding
Copy link
Member Author

Ha! Took me a while to decipher that error, then I noticed I did that already, its in the first line of the PR description:

This update breaks MSRV 1.29 so cannot be merged until we merge: #222

@stevenroose
Copy link
Collaborator

Can be rebased now that #222 is in.

Upgrade `rust-bitcoin` dependency to the newly released
version (0.29.0). Includes fixing newly deprecated APIs.
Add release notes and increase the crate minor version to 0.16.0

Justified because we just bumped the `rust-bitcoin` minor version.
@tcharding
Copy link
Member Author

Rebase only, no other changes.

@DanGould
Copy link

tACK e6f334f 👍

@dpc dpc merged commit 661b58d into rust-bitcoin:master Aug 18, 2022
@tcharding tcharding deleted the 08-09-upgrade-bitcoin branch August 22, 2022 01:33
@tcharding
Copy link
Member Author

Can we have a release as well please? CC @stevenroose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants