WIP: Upgrade the bitcoin dependency #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade the `bitcoin` dependency to the soon-to-be-released version. Doing this patch lead to: - rust-bitcoin/rust-bitcoin#2038 - rust-bitcoin/rust-bitcoin#2039 Once they merge and we release then this PR can come off WIP.
|
Your PR rust-bitcoin/rust-bitcoin#2039 is supposed to add enum with name |
|
FTR rust-bitcoin/rust-bitcoin#2039 won't go in the |
lateminer
added a commit
to CoinBlack/rust-blackcoin
that referenced
this pull request
Oct 27, 2023
As this function won't be included in `rust-bitcoin v0.31.0` release according to rust-bitcoin/rust-bitcoincore-rpc#308 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the
bitcoindependency to the soon-to-be-released version.Doing this patch lead to:
consensus::deserialize_hexfunction rust-bitcoin#2039Once they merge and we release then this PR can come off WIP.
Done on top of bitcoin master branch while on commit:
7fd9b89e Merge rust-bitcoin/rust-bitcoin#2010: Use weight type for stripped_sizewith the addition of the two PRs above.