Updating to bitcoin 0.25 and MSRV 1.29 #152
Conversation
|
It look like the conflict is caused by a bug in rust-secp (seems secp256k1-sys 0.3.0 has |
|
We can fix this as part of rust-bitcoin/rust-secp256k1#237 -- once we get that PR merged I'll quickly release secp-sys 0.3.1 and there should no longer be a conflict. |
|
You cannot update bitcoin to 0.25 without also increasing the MSRV of this library. |
dr-orlovsky
changed the title
|
@apoelstra MSRV updated as a part of this PR |
There was a problem hiding this comment.
tAck 7f2482a. Why do we still need the pinning for cc version? It does not seem to work without it.
|
I tried to have a build w/o it and it did not pass |
|
Is it possible to release Miniscript 2.1.0 supporting bitcoin 0.25? |
|
Yes, that is the current plan. We should have the release soon. cc @apoelstra |
|
Released 3.0.0 which uses 0.25 |
This is trivial, but urgently required for the projects already using bitcoin 0.25 due to secp256k1 library version conflict (you can't use miniscript v2.0 with bitcoin 0.25 in the same crate for now)