allow disabling the checksum with alternate Display
#478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let us avoid some allocations when formatting descriptors, and make it simpler to selectively append a checksum.
This allows us to remove the checksum with {:#}, and avoid extra
allocations in all cases. Deprecates the old to_string_no_checksum()
methods, which were inefficient and (in the case of Taproot) not
even exported.
Fixes rust-bitcoin#477
sanket1729
approved these changes
Oct 18, 2022
| impl<'f, 'a> fmt::Write for Formatter<'f, 'a> { | ||
| fn write_str(&mut self, s: &str) -> fmt::Result { | ||
| self.fmt.write_str(s)?; | ||
| if self.eng.input(s).is_ok() { |
There was a problem hiding this comment.
nit: This can be written as self.engine.input(s).map_err(|| fmt::Error)
sanket1729
added a commit
to sanket1729/elements-miniscript
that referenced
this pull request
Oct 21, 2022
…022_10 72dab64 (HEAD -> master, upstream/master, origin/master, origin/HEAD) Merge rust-bitcoin/rust-miniscript#478: allow disabling the checksum with alternate `Display` Also had to fix a bunch of test cases with bare descriptors without el prefix. Add a small API to get the nested segwit descriptors without the el prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #477