Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow disabling the checksum with alternate Display #478

Merged
merged 3 commits into from
Oct 18, 2022
Merged

allow disabling the checksum with alternate Display #478

merged 3 commits into from
Oct 18, 2022

Commits on Oct 18, 2022

  1. checksum: pull computation apart into an engine 

    This will let us avoid some allocations when formatting descriptors,
and make it simpler to selectively append a checksum.
    @apoelstra
    apoelstra committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    84f0292 View commit details
    Browse the repository at this point in the history

  2. checksum: use wrapper around fmt::Formatter for all descriptor types 

    This allows us to remove the checksum with {:#}, and avoid extra
allocations in all cases. Deprecates the old to_string_no_checksum()
methods, which were inefficient and (in the case of Taproot) not
even exported.

Fixes rust-bitcoin#477
    @apoelstra
    apoelstra committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    7577e8c View commit details
    Browse the repository at this point in the history

  3. fixes for 1.41.0

    @apoelstra
    apoelstra committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    7f5bbdf View commit details
    Browse the repository at this point in the history