Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more support for targets #4

Open
Douile opened this issue Apr 17, 2021 · 9 comments
Open

Add more support for targets #4

Douile opened this issue Apr 17, 2021 · 9 comments
Labels
enhancement New feature or request

Comments

@Douile
Copy link
Member

Douile commented Apr 17, 2021

cross seems to be a good way to support more targets easily, they have a docker image

@Douile Douile added the enhancement New feature or request label Apr 17, 2021
@fcsonline
Copy link

I have seen that right now there is no support arm-unknown-linux-gnueabi, and it would be awesome to have.

👍 to use cross to support much more targets.

@Canvas02
Copy link

An arm build for mac os would be great for M1

@de-sh
Copy link

de-sh commented Apr 25, 2022

cross seems to be a good way to support more targets easily, they have a docker image

I believe the main blocker here is the fact that cross uses docker images to host all necessary linker dependencies(CC, AR) and requires access to the docker daemon, which we do not have in the case of GitHub actions, if I am not wrong.

@theHamsta
Copy link

Cross seems to use different targets in their CI https://github.com/cross-rs/cross/blob/main/.github/workflows/ci.yml

@Douile
Copy link
Member Author

Douile commented Apr 28, 2022

By moving to a composite action (https://docs.github.com/en/actions/creating-actions/creating-a-composite-action) instead of a docker action it may be possible to deterministically choose a docker image to use.

@Douile
Copy link
Member Author

Douile commented May 4, 2022

A design for implementing this could be:

  • Maintain a subset of actions for each target (essentially just base on the cross docker image and call build)

In main action:

  1. Select and call subaction based on target (pass through settings)
  2. Upload output

@larsnaesbye
Copy link

An arm build for mac os would be great for M1

I agree! 'aarch64-apple-darwin' would be much preferable for performance reasons. Rosetta 2 is OK, but of course emulation eats cycles,

@larsnaesbye
Copy link

larsnaesbye commented Nov 9, 2022

@Douile - Wouldn't it be possible to compile for aarch64-apple-darwin with a macOS SDK 11.x SDK, since ARM support began with macOS 11? One could be taken from here: https://github.com/phracker/MacOSX-SDKs/releases/download/11.3/MacOSX11.3.sdk.tar.xz
Since older versions are no longer supported, maybe that's another reason to move to a newer SDK as well.

@Douile
Copy link
Member Author

Douile commented Mar 12, 2023

https://github.com/houseabsolute/actions-rust-cross seems to implement this behaviour. although without the included upload for releases. However this can be implemented with other actions in a more modular way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

6 participants