-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more support for targets #4
Comments
I have seen that right now there is no support 👍 to use cross to support much more targets. |
An arm build for mac os would be great for M1 |
I believe the main blocker here is the fact that cross uses docker images to host all necessary linker dependencies(CC, AR) and requires access to the docker daemon, which we do not have in the case of GitHub actions, if I am not wrong. |
Cross seems to use different targets in their CI https://github.com/cross-rs/cross/blob/main/.github/workflows/ci.yml |
By moving to a composite action (https://docs.github.com/en/actions/creating-actions/creating-a-composite-action) instead of a docker action it may be possible to deterministically choose a docker image to use. |
A design for implementing this could be:
In main action:
|
I agree! 'aarch64-apple-darwin' would be much preferable for performance reasons. Rosetta 2 is OK, but of course emulation eats cycles, |
@Douile - Wouldn't it be possible to compile for |
https://github.com/houseabsolute/actions-rust-cross seems to implement this behaviour. although without the included upload for releases. However this can be implemented with other actions in a more modular way. |
cross seems to be a good way to support more targets easily, they have a docker image
The text was updated successfully, but these errors were encountered: