Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp_string should take String. #34

Open
cheako opened this issue Jan 20, 2021 · 0 comments
Open

exp_string should take String. #34

cheako opened this issue Jan 20, 2021 · 0 comments

Comments

@cheako
Copy link

cheako commented Jan 20, 2021

I don't know how ppl feel about API changes, I'd guess there are so few users it doesn't matter as long as the minor version id bumped appropriately.

APIs should take owned values when they need an owned clone of something, instead of calling to_owned() or in this case to_string().

See: https://www.philipdaniels.com/blog/2019/rust-api-design/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cheako