Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with nightly-2021-09-26: unknown pass name 'sancov' #276

Closed
dtolnay opened this issue Sep 26, 2021 · 2 comments · Fixed by #277
Closed

Incompatible with nightly-2021-09-26: unknown pass name 'sancov' #276

dtolnay opened this issue Sep 26, 2021 · 2 comments · Fixed by #277

Comments

@dtolnay
Copy link
Contributor

dtolnay commented Sep 26, 2021

I noticed that serde_json's fuzz target does not build using the most recent nightly. It's been working for a long time so this is a recent breakage.

Repro:

$ cargo fuzz init
$ cargo +nightly-2021-09-25 fuzz build  # works
$ cargo +nightly-2021-09-26 fuzz build

error: failed to run LLVM passes: unknown pass name 'sancov'

error: could not compile `once_cell` due to previous error
warning: build failed, waiting for other jobs to finish...
error: build failed
Error: failed to build fuzz script: "cargo" "build" "--manifest-path" "fuzz/Cargo.toml" "--target" "x86_64-unknown-linux-gnu" "--release" "--bins"

The upstream commit range is rust-lang/rust@7342213...addb4da.

@dtolnay
Copy link
Contributor Author

dtolnay commented Sep 26, 2021

dtolnay added a commit to serde-rs/json that referenced this issue Sep 26, 2021
dtolnay added a commit to dtolnay/serde-yaml that referenced this issue Sep 26, 2021
@nagisa
Copy link
Member

nagisa commented Sep 26, 2021 via email

ctz added a commit to rustls/rustls that referenced this issue Sep 26, 2021
djc pushed a commit to rustls/rustls that referenced this issue Sep 26, 2021
Dirbaio added a commit to smoltcp-rs/smoltcp that referenced this issue Sep 26, 2021
rbradford added a commit to rbradford/cloud-hypervisor that referenced this issue Sep 27, 2021
This resolves issues between released version of cargo fuzz and nightly.

See rust-fuzz/cargo-fuzz#276

Signed-off-by: Rob Bradford <robert.bradford@intel.com>
MrXinWang pushed a commit to cloud-hypervisor/cloud-hypervisor that referenced this issue Sep 27, 2021
This resolves issues between released version of cargo fuzz and nightly.

See rust-fuzz/cargo-fuzz#276

Signed-off-by: Rob Bradford <robert.bradford@intel.com>
bmc-msft added a commit to microsoft/onefuzz that referenced this issue Sep 27, 2021
sunfishcode added a commit to bytecodealliance/cap-std that referenced this issue Oct 6, 2021
sunfishcode added a commit to bytecodealliance/cap-std that referenced this issue Oct 7, 2021
)

The main tricky part here is that `fs_utf8::DirEntry::file_name()` now
has to return `io::Result<String>` instead of just `String` so that it
can fail if the name is unencodable.

Fixes #186.

* Make the `test_invalid_utf8` tolerant of OS's which disallow such paths.

It appears MacOS rejects invalid filenames; on such platforms, don't
try to test that we can open invalid filenames.

* Temporarily disable fuzz test compilation.

This works around rust-fuzz/cargo-fuzz#276.

* Remove the ubuntu-16.04 builds, as ubuntu-16.04 is no longer supported.
snev68 added a commit to snev68/cap-std that referenced this issue Aug 5, 2024
…188)

The main tricky part here is that `fs_utf8::DirEntry::file_name()` now
has to return `io::Result<String>` instead of just `String` so that it
can fail if the name is unencodable.

Fixes #186.

* Make the `test_invalid_utf8` tolerant of OS's which disallow such paths.

It appears MacOS rejects invalid filenames; on such platforms, don't
try to test that we can open invalid filenames.

* Temporarily disable fuzz test compilation.

This works around rust-fuzz/cargo-fuzz#276.

* Remove the ubuntu-16.04 builds, as ubuntu-16.04 is no longer supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants