Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

src: Remove executable bit from source files #289

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

cgwalters
Copy link
Contributor

I know this seems silly, but RPM builds of
https://github.com/coreos/coreos-installer/
are failing for me because RPM sticks these source files in
"debugsource" directories, and then a "linter" check notices
they appear to be executable but lack a shebang #! line.

There's no reason for source to be directly executable,
so remove that bit.

I know this seems silly, but RPM builds of
https://github.com/coreos/coreos-installer/
are failing for me because RPM sticks these source files in
"debugsource" directories, and then a "linter" check notices
they appear to be executable but lack a shebang `#!` line.

There's no reason for source to be directly executable,
so remove that bit.
@AndyGauge AndyGauge merged commit 44c9240 into rust-lang-deprecated:master Mar 25, 2020
@bgilbert
Copy link

bgilbert commented Aug 1, 2020

Commit 542c12c reinstated the execute bit on lib.rs (and, indeed, every other file it touched).

@AndyGauge
Copy link
Contributor

AndyGauge commented Aug 2, 2020 via email

@cgwalters
Copy link
Contributor Author

Andy, what's the umask value on your system? Is your editor creating files with the executable bit by default for some reason?

@AndyGauge
Copy link
Contributor

I'm using windows subsystem for linux on the machine I just released from. The file system that holds the files is NTFS and the file system adapter ends up causing these problems.
I'll be releasing 0.12.4 with a mac to avoid the problem.

@AndyGauge
Copy link
Contributor

OK, I've published 0.12.4 to address this problem. I'll try to be more cognizant of the file permissions on all of the codebases I touch because of this, but I do apologize for this learning experience impacting other's workflow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants