Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Builder::whitelist_type; deprecate Builder::whitelisted_type #987

Closed
3 tasks
fitzgen opened this issue Sep 13, 2017 · 3 comments
Closed
3 tasks

Add Builder::whitelist_type; deprecate Builder::whitelisted_type #987

fitzgen opened this issue Sep 13, 2017 · 3 comments

Comments

@fitzgen
Copy link
Member

fitzgen commented Sep 13, 2017

The CLI flag is --whitelist-type, so we should be consistent and remove the "ed" from the builder method.

  • Rename Builder::whitelisted_type to Builder::whitelist_type
  • Add Builder::whitelisted_type that delegates to whitelist_type
  • Mark whitelisted_type as #[deprecated = "use whitelist_type instead"]
@highfive
Copy link

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@treiff
Copy link
Contributor

treiff commented Sep 15, 2017

Going to grab this one, then maybe start looking at some of the slightly more difficult ones.

@highfive: assign me

@highfive
Copy link

Hey @treiff! Thanks for your interest in working on this issue. It's now assigned to you!

treiff added a commit to treiff/rust-bindgen that referenced this issue Sep 15, 2017
Closes rust-lang#987

Also, we were making a call to the now deprecated `Builder::hide_type`,
changed that over to call `Builder::blacklist_type.
bors-servo pushed a commit that referenced this issue Sep 15, 2017
Depreciate `Builder::whitelisted_type`.

Closes #987

Also, we were making a call to the now deprecated `Builder::hide_type`,
changed that over to call `Builder::blacklist_type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants