Bring rustup.js and markup into alingment with rust-www #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes rustup.js the same as on rust-www, pulls in some of the language from rust-www, pulls in some fixes to platform detection, fixes some css.
|
This needs to be reviewed and merged with rust-lang/prev.rust-lang.org#1128. |
|
LGTM, but maybe we should just remove |
|
@Diggsey seems ok to me, except for risk of possible unanticipated drift between the two. |
|
I'm not inclined to work on this further, but doing the change @Diggsey suggested sounds fine. |
|
@bors r+ |
|
📌 Commit c7fe58c has been approved by |
bors
added a commit
that referenced
this pull request
Jul 1, 2018
Bring rustup.js and markup into alingment with rust-www This makes rustup.js the same as on rust-www, pulls in some of the language from rust-www, pulls in some fixes to platform detection, fixes some css.
|
💔 Test failed - status-travis |
AJ-Ianozi
pushed a commit
to AJ-Ianozi/getada-download
that referenced
this pull request
Mar 9, 2024
Bring rustup.js and markup into alingment with rust-www
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes rustup.js the same as on rust-www, pulls in
some of the language from rust-www, pulls in some fixes
to platform detection, fixes some css.