Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update msrv to v1.73 #71

Merged
merged 1 commit into from
Jan 4, 2024
Merged

chore(deps): update msrv to v1.73 #71

merged 1 commit into from
Jan 4, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 15, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change Pending
rust minor 1.70 -> 1.73 1.75 (+1)

Release Notes

rust-lang/rust (rust)

v1.73

Compare Source

==========================

Language

Compiler

Refer to Rust's [platform support page][platform-support-doc]
for more information on Rust's tiered platform support.

Libraries

Stabilized APIs

These APIs are now stable in const contexts:

Cargo

Misc

Compatibility Notes

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent
significant improvements to the performance or internals of rustc and related
tools.

v1.72

Compare Source

===========================

v1.71

Compare Source

===========================


Configuration

📅 Schedule: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title chore(deps): update msrv to v1.72 chore(deps): update msrv to v1.73 Dec 29, 2023
@Muscraft Muscraft merged commit 6a1ed2a into master Jan 4, 2024
16 checks passed
@Muscraft Muscraft deleted the renovate/rust-1.x branch January 4, 2024 21:23
@klensy
Copy link

klensy commented Jan 11, 2024

Why msrv bump, is there some deps require this?

@epage
Copy link
Contributor

epage commented Jan 11, 2024

Our MSRV is strictly N-2 (which is wider than primary target users, cargo and rustc). This avoids ambiguity over our MSRV policy that can come from on-need updates as "what works for me now" can easily be confused with "matches my policy". This also avoids debates over where the line is for when a change justifies bumping the MSRV, which can be draining for all involved. In particular, new contributors are less likely to be confident enough to advocate for a new MSRV change, so this gives them implicit permission to use new features.

If this is of concern, please clarify whether you are requesting a lazy approach or a wider window and what problem would be solved by doing so.

@Muscraft Muscraft mentioned this pull request Jun 6, 2024
@epage
Copy link
Contributor

epage commented Jun 6, 2024

@klensy we went ahead and dropped the MSRV to 1.65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants