Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming convention for macros #135

Closed
dtolnay opened this issue Oct 29, 2017 · 3 comments
Closed

Naming convention for macros #135

dtolnay opened this issue Oct 29, 2017 · 3 comments

Comments

@dtolnay
Copy link
Member

dtolnay commented Oct 29, 2017

The C-CASE table needs a line for macros. I believe the convention is snake_case!.
@dtolnay
Copy link
Member Author

dtolnay commented Oct 29, 2017

Added in f59ec10.

@dtolnay dtolnay closed this as completed Oct 29, 2017
@ExpHP
Copy link

ExpHP commented Nov 11, 2017 •
edited
Loading

Should this recommendation be applied unilaterally, or is it more subtle? I've been using PascalCase! for macros that expand into types. (e.g. Array![i32; 5; 4; 3] which expands into [[[i32; 3]; 4]; 5])

@dtolnay dtolnay mentioned this issue Nov 11, 2017
Open
@dtolnay
Copy link
Member Author

dtolnay commented Nov 11, 2017

Thanks! I did not consider type macros when I wrote this. I filed #145 to follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ExpHP @dtolnay