Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where missing end would default to "origin/master" then get compared to a sha #71

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

dillona
Copy link
Contributor

@dillona dillona commented Apr 2, 2020

Otherwise you get this:

$ cargo-bisect-rustc --prompt --test-dir=foo --start e768d6f0bc6
bisecting ci builds
starting at e768d6f0bc6, ending at origin/master
fetching (via local git) commits from e768d6f0bc6 to origin/master
opening existing repository at "rust.git"
refreshing repository
looking up first commit
looking up second commit
checking that commits are by bors and thus have ci artifacts...
finding bors merge commits
found 21 bors merge commits in the specified range
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `"76b11980ad416c3ad6143504c2277757ecacf9b5"`,
 right: `"origin/master"`', /home/dillona/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-bisect-rustc-0.4.0/src/main.rs:970:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@chrissimpkins
Copy link
Member

Thoughts @pnkfelix & @spastorino?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants