Fix git commit retrieval via GitHub API when --end commit SHA is not specified
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnkfelix
reviewed
Apr 13, 2020
src/github.rs
Outdated
| // HEAD commit as the end commit in this case | ||
| if self.sha == "origin/master" { | ||
| format!( | ||
| "https://api.github.com/repos/{OWNER}/{REPO}/commits/HEAD", |
There was a problem hiding this comment.
would commits/master here work just as well?
if so, I think that would be clearer. (I'll be honest, I'm not clear on what HEAD is supposed to denote when querying github...)
There was a problem hiding this comment.
would commits/master here work just as well?
Yes it looks like it:
There was a problem hiding this comment.
Pushed this change in be54918
|
Ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
Also updates project dependencies to current release versions and adds changelog updates for a v0.4.1 release.