Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of deprecated binaries in crates.toml #4321

Open
letheed opened this issue Jul 24, 2017 · 2 comments
Open

Handling of deprecated binaries in crates.toml #4321

letheed opened this issue Jul 24, 2017 · 2 comments
Labels
Command-install S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.

Comments

@letheed
Copy link

letheed commented Jul 24, 2017

cargo-edit 0.1.6 used to provide the following binaries: ["cargo-add", "cargo-list", "cargo-rm"].
cargo-edit 0.2.0 now provides ["cargo-add", "cargo-rm", "cargo-upgrade"].

I updated cargo-edit by running cargo install-update cargo-edit[edited typo] which in turn ran cargo install -f cargo-edit. Now, I have with the following in my .crates.toml:

"cargo-edit 0.1.6 (registry+https://github.com/rust-lang/crates.io-index)" = ["cargo-list"]
"cargo-edit 0.2.0 (registry+https://github.com/rust-lang/crates.io-index)" = ["cargo-add", "cargo-rm", "cargo-upgrade"]

Is that the expected behavior? This seems to leave 0.1.6 in an inconsistent state since cargo-add and cargo-rm are now v0.2.0 when cargo-list is still v0.1.6.

Is this acceptable and can this be improved, or are subcommands like cargo-install-update expected to handle this?

@nabijaczleweli
Copy link
Contributor

(dropping by to say that it's cargo install-update, not cargo update-installed)

@alexcrichton
Copy link
Member

I think this is semi-expected today but probably not the right behavior, we should likely just uninstall all binaries associated with a crate rather than just the subset being overridden.

@weihanglo weihanglo added the S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted. label May 24, 2023
@epage epage added S-triage Status: This issue is waiting on initial triage. S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted. and removed S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted. S-triage Status: This issue is waiting on initial triage. labels Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Command-install S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.
Projects
None yet
Development

No branches or pull requests

5 participants