Detect incorrectly named cargo.toml

[pnkfelix]

A new user following tutorials won't necessarily use cargo new; they may create files by hand.

In practice, I have found that such users may accidentally create cargo.toml instead of Cargo.toml.

If Cargo.toml is missing, cargo should detect the presence of a file like cargo.toml and suggest that the user rename it to Cargo.toml.

[hedonhermdev]

Hey can I take this up?

[ehuss]

Of course, let me know if you have any questions. There is a contributor guide here if you need more information on working on cargo.

Also, just for the future, you are welcome to automatically claim an issue yourself (as noted here, you can use @rustbot claim if you want to make it formal).

[hedonhermdev]

Should I also add a test for this?

[ehuss]

Yea, that would be good! We try to add tests for every addition and fix when possible.

[hedonhermdev]

Hey, so the filesystem on MacOS is case-insensitive and treats cargo.toml and Cargo.toml as the same. So I'm not sure how to test it.

[ehuss]

The test could create a file (Test) and then try to open it with lowercase (test) and if that succeeds, you'll know you're on a case-insensitive filesystem. I'm not sure how you're planning to implement it for that case, if you will silently allow it, issue a warning, or an error. I'm thinking in the spirit of the issue, it might be good to detect it, but I'm not sure how difficult that would be.

[Rustin170506]

@hedonhermdev Are you still fixing this issue? I want to try to improve it! If you are not trying to fix it, could you please let me know?

[hedonhermdev]

Hey yes you can continue with it

[Rustin170506]

@ehuss Could you offer some help please? I seem to be having trouble finding a place to add that suggestion. Is there a place where these commands uniformly parse Cargo.toml that can be modified?

[ehuss]

I think it might go here where it is loaded, and just check for a NotFound error.

[Rustin170506]

@rustbot claim

[Rustin170506]

I think it might go here where it is loaded, and just check for a NotFound error.

There still seems to be a lot of places where that path is being used. I try to try to warn them uniformly.