Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add .fleet to .gitignore #11218

Closed
wants to merge 1 commit into from

Conversation

Muscraft
Copy link
Member

When trying out Jetbrains Fleet, I noticed that it added a new directory for its configuration files. I thought it would be a good idea to add it to the .gitignore as it entered public preview earlier today.

@rust-highfive
Copy link

r? @ehuss

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2022
Comment on lines 12 to +14
.idea/
.vscode/
.fleet/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I feel like we shouldn't be ignoring every random editor's special files but should instead have users configure their personal gitignores to ignore their editor.

(note, this applies to more than just fleet)

Copy link
Member

@weihanglo weihanglo Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second epage's opinion, though not opposed to add it if it becomes popular.

See also: #7578

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great example of slippery slope :)

If we remove all, maybe we should have a comment saying how to do the per-use ignore since it seems to be common for people to just want to put it in here instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is a good solution! I'll close this PR for now then

@Muscraft Muscraft closed this Oct 12, 2022
@Muscraft Muscraft deleted the update-gitignore branch January 25, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants