Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add .fleet to .gitignore #11218

Closed
wants to merge 1 commit into from
Closed

chore: Add .fleet to .gitignore #11218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ rustc
__pycache__
.idea/
.vscode/
.fleet/
Comment on lines 12 to +14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I feel like we shouldn't be ignoring every random editor's special files but should instead have users configure their personal gitignores to ignore their editor.

(note, this applies to more than just fleet)

Copy link
Member

@weihanglo weihanglo Oct 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second epage's opinion, though not opposed to add it if it becomes popular.

See also: #7578

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great example of slippery slope :)

If we remove all, maybe we should have a comment saying how to do the per-use ignore since it seems to be common for people to just want to put it in here instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is a good solution! I'll close this PR for now then

*.iml
*.swp