refactor(toml): Flatten manifest parsing #13589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is prep for adding more
rustbot
added
A-cli
rustbot
added
the
A-infrastructure
I plan to add a true `original`
So diagnostics can use this for reporting.
- So we can eventually track the `original` - So we can track spans for diagnostics
So we can track spans for diagnostics
Before, we split things up. This makes it so everything has access to every step so we can reap the benefits - use `&str` and `ImDocument` for diagnostics - access `original`
Moving this out for collapsing `convert_toml`
This is prep for shifting unused keys warnings out of `convert_toml`
This makes it act more like everything else, making this easier to evolve over time.
This is in an effort to remove `convert_toml`
This is part of an effort to remove `convert_toml`
This simplifies the interface for `toml/mod.rs` and reduces the work we do.
This is to work towards tracking everything needed for diagnostics in `Manifest`
Muscraft
approved these changes
Mar 15, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
weihanglo
reviewed
Mar 15, 2024
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Mar 15, 2024
refactor: Expose source/spans to Manifest for emitting lints ### What does this PR try to resolve? This is a follow up to #13589. This does nothing on its own. This is meant to short-circuit some of my refactorings so Muscraft can start on their work on adding lints while I work to move out existing warnings into being able to be converted to lints. ### How should we test and review this PR? This includes documentation changes suggested in #13589 ### Additional information
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 16, 2024
Update cargo 6 commits in 7065f0ef4aa267a7455e1c478b5ccacb7baea59c..2fe739fcf16c5bf8c2064ab9d357f4a0e6c8539b 2024-03-12 13:25:15 +0000 to 2024-03-15 21:39:18 +0000 - feat: Add 'open-namespaces' feature (rust-lang/cargo#13591) - refactor: Expose source/spans to Manifest for emitting lints (rust-lang/cargo#13593) - feat(tree): Control `--charset` via auto-detecting config value (rust-lang/cargo#13337) - refactor(toml): Flatten manifest parsing (rust-lang/cargo#13589) - fix: strip feature dep when dep is dev dep (rust-lang/cargo#13518) - fix(ci): bump check error when PR is behind master (rust-lang/cargo#13581) r? ghost
bors
added a commit
that referenced
this pull request
Mar 28, 2024
fix(toml): Warn on unused workspace.dependencies keys on virtual workspaces ### What does this PR try to resolve? This splits out refactors that build on #13589 in preparation for resolving #13456. As part of those refactors, I noticed an inconsistency on when we warn for unused keys. We have parallel code paths between `to_virtual_manifest` and `to_real_manifest` and only one got updated on a change. This syncs them up. Hopefully the end state this builds to will reduce duplication. ### How should we test and review this PR? ### Additional information
bors
added a commit
that referenced
this pull request
Mar 28, 2024
fix(toml): Warn on unused workspace.dependencies keys on virtual workspaces ### What does this PR try to resolve? This splits out refactors that build on #13589 in preparation for resolving #13456. As part of those refactors, I noticed an inconsistency on when we warn for unused keys. We have parallel code paths between `to_virtual_manifest` and `to_real_manifest` and only one got updated on a change. This syncs them up. Hopefully the end state this builds to will reduce duplication. ### How should we test and review this PR? ### Additional information
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is just a clean up but the goals are
&str,ImDocument, etc inManifestby making each accessible in the creation of aManifestcargo publishstripping of dev-dependencies and their feature activations by allowing aSummaryto be created from any "resolved"TomlManifestTomlManifestso they get included incargo publish, reducing the work done on registry dependencies and resolving problems like cargo publish has bad error message when explicit[[bench]]isn't inpackage.include#13456Along the way, this fixed a bug where we were not reporting warnings from virtual manifests
How should we test and review this PR?
Additional information