Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[beta] When uplifting directories, symlink them instead of hard-link them. #4739
Conversation
rust-highfive
assigned
alexcrichton
Nov 22, 2017
This comment has been minimized.
This comment has been minimized.
rust-highfive
commented
Nov 22, 2017
|
(rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
rust-highfive
commented
Nov 22, 2017
|
|
This comment has been minimized.
This comment has been minimized.
|
Ok, let's get this going! @bors r+ After this is merged, you'll need to send a PR against rust-lang/rust, as desribed here: https://github.com/rust-lang-nursery/rust-forge/blob/master/beta-backporting.md#backporting-in-rust-langcargo |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Nov 22, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 2c6a0fe
into
rust-lang:rust-1.22.0
Nov 22, 2017
kennytm
deleted the
kennytm:backport-4672
branch
Nov 22, 2017
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 22, 2017
kennytm
referenced this pull request
Nov 22, 2017
Merged
[stable] Update cargo to fix breakage on macOS High Sierra; Update version to 1.22.1. #46183
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 22, 2017
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kennytm commentedNov 22, 2017
Backport of #4672 to 1.22 (cargo 0.23)
The current stable RC (cee38cd) contains #4616 but not #4672. Without the latter it is known to cause #4671 on APFS (enabled by default on macOS 10.13 "High Sierra").
The issue was found by kpy3 on https://internals.rust-lang.org/t/rust-1-22-0-prerelease-testing/6282/2.