[beta] When uplifting directories, symlink them instead of hard-link them. #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
Ok, let's get this going! @bors r+ After this is merged, you'll need to send a PR against rust-lang/rust, as desribed here: https://github.com/rust-lang-nursery/rust-forge/blob/master/beta-backporting.md#backporting-in-rust-langcargo |
|
📌 Commit 2c6a0fe has been approved by |
bors
added a commit
that referenced
this pull request
Nov 22, 2017
[beta] When uplifting directories, symlink them instead of hard-link them. Backport of #4672 to 1.22 (cargo 0.23) The current stable RC (cee38cd) contains #4616 *but not* #4672. Without the latter it is known to cause #4671 on APFS (enabled by default on macOS 10.13 "High Sierra"). The issue was found by kpy3 on https://internals.rust-lang.org/t/rust-1-22-0-prerelease-testing/6282/2.
|
☀️ Test successful - status-appveyor, status-travis |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 22, 2017
This backport includes rust-lang/cargo#4739, required for building projects in debug mode with cargo on macOS High Sierra.
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 22, 2017
[stable] Update cargo to fix breakage on macOS High Sierra; Update version to 1.22.1. This backport includes rust-lang/cargo#4739, required for building projects in debug mode with Cargo on macOS High Sierra (see the Cargo PR for details).
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 22, 2017
[stable] Update cargo to fix breakage on macOS High Sierra; Update version to 1.22.1. This backport includes rust-lang/cargo#4739, required for building projects in debug mode with Cargo on macOS High Sierra (see the Cargo PR for details).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4672 to 1.22 (cargo 0.23)
The current stable RC (cee38cd) contains #4616 but not #4672. Without the latter it is known to cause #4671 on APFS (enabled by default on macOS 10.13 "High Sierra").
The issue was found by kpy3 on https://internals.rust-lang.org/t/rust-1-22-0-prerelease-testing/6282/2.