New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Update cargo to fix breakage on macOS High Sierra; Update version to 1.22.1. #46183

Merged
merged 2 commits into from Nov 23, 2017

Conversation

Projects
None yet
5 participants
@kennytm
Member

kennytm commented Nov 22, 2017

This backport includes rust-lang/cargo#4739, required for building projects in debug mode with Cargo on macOS High Sierra (see the Cargo PR for details).

[stable] Update cargo.
This backport includes rust-lang/cargo#4739, required for building projects
in debug mode with cargo on macOS High Sierra.
@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Nov 22, 2017

Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Nov 22, 2017

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Nov 22, 2017

Member

Unfortunately we have no easy means of producing another stable build , we can do so manually but I will likely be out sick at least this morning and maybe all day :(

Member

alexcrichton commented Nov 22, 2017

Unfortunately we have no easy means of producing another stable build , we can do so manually but I will likely be out sick at least this morning and maybe all day :(

@kennytm kennytm changed the title from [stable] Update cargo to breakage on macOS High Sierra. to [stable] Update cargo for breakage on macOS High Sierra. Nov 22, 2017

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Nov 22, 2017

Member

@alexcrichton Sorry to hear that. Is it possible to hold off the release for macOS until Cargo is patched? (Linux and Windows are not affected.)

(I also wonder why no one reported it during beta, I also don't recall encountering this when using beta.)

Member

kennytm commented Nov 22, 2017

@alexcrichton Sorry to hear that. Is it possible to hold off the release for macOS until Cargo is patched? (Linux and Windows are not affected.)

(I also wonder why no one reported it during beta, I also don't recall encountering this when using beta.)

@kennytm kennytm changed the title from [stable] Update cargo for breakage on macOS High Sierra. to [stable] Update cargo to fix breakage on macOS High Sierra; Update version to 1.22.1. Nov 22, 2017

@aturon

This comment has been minimized.

Show comment
Hide comment
@aturon

aturon Nov 22, 2017

Member

@bors: r+ p=100 point release

Member

aturon commented Nov 22, 2017

@bors: r+ p=100 point release

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 22, 2017

Contributor

📌 Commit a9749ef has been approved by aturon

Contributor

bors commented Nov 22, 2017

📌 Commit a9749ef has been approved by aturon

@kennytm kennytm referenced this pull request Nov 22, 2017

Merged

add -Zunpretty=hir-tree #45721

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 22, 2017

Contributor

⌛️ Testing commit a9749ef with merge bb408b5...

Contributor

bors commented Nov 22, 2017

⌛️ Testing commit a9749ef with merge bb408b5...

bors added a commit that referenced this pull request Nov 22, 2017

Auto merge of #46183 - kennytm:backport-cargo-4739, r=aturon
[stable] Update cargo to fix breakage on macOS High Sierra; Update version to 1.22.1.

This backport includes rust-lang/cargo#4739, required for building projects in debug mode with Cargo on macOS High Sierra (see the Cargo PR for details).
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 22, 2017

Contributor

💔 Test failed - status-appveyor

Contributor

bors commented Nov 22, 2017

💔 Test failed - status-appveyor

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Nov 22, 2017

Member

@bors retry #43402

Not now!!

Member

kennytm commented Nov 22, 2017

@bors retry #43402

Not now!!

@kennytm kennytm referenced this pull request Nov 22, 2017

Merged

Make accesses to fields of packed structs unsafe #44884

0 of 4 tasks complete
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 22, 2017

Contributor

⌛️ Testing commit a9749ef with merge 05e2e1c...

Contributor

bors commented Nov 22, 2017

⌛️ Testing commit a9749ef with merge 05e2e1c...

bors added a commit that referenced this pull request Nov 22, 2017

Auto merge of #46183 - kennytm:backport-cargo-4739, r=aturon
[stable] Update cargo to fix breakage on macOS High Sierra; Update version to 1.22.1.

This backport includes rust-lang/cargo#4739, required for building projects in debug mode with Cargo on macOS High Sierra (see the Cargo PR for details).
@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Nov 22, 2017

Member

(The fix of the spurious error, #45170, was merged after 1.22.0 is branched off as beta, thus this spurious error can still happen)

Member

kennytm commented Nov 22, 2017

(The fix of the spurious error, #45170, was merged after 1.22.0 is branched off as beta, thus this spurious error can still happen)

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 23, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 05e2e1c to stable...

Contributor

bors commented Nov 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 05e2e1c to stable...

@bors bors merged commit a9749ef into rust-lang:stable Nov 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@kennytm kennytm deleted the kennytm:backport-cargo-4739 branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment