Prevent RUSTFLAGS from breaking probing #4807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks for the PR! Can you be sure to add a test as well? I'm also somewhat wary about doing this, in general Cargo tries to interpret nothing going down to rustc to give it as much freedom as possible. For example this doesn't correctly handle the case of |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Dec 15, 2017
Help Cargo tolerate RUSTFLAGS="--print=native-static-libs" Alternative to rust-lang/cargo#4807 Having this "error" message was a mistake, as it's firing at exactly wrong time when Cargo is trying to read the output of other print commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4761, enables support for
RUSTFLAGS="--print=native-static-libs" cargo build