Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help Cargo tolerate RUSTFLAGS="--print=native-static-libs" #46705

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Help Cargo tolerate RUSTFLAGS="--print=native-static-libs" #46705

merged 1 commit into from
Dec 15, 2017

Conversation

kornelski
Copy link
Contributor

Alternative to rust-lang/cargo#4807

Having this "error" message was a mistake, as it's firing at exactly wrong time when Cargo is trying to read the output of other print commands.

@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2017
@arielb1
Copy link
Contributor

arielb1 commented Dec 13, 2017

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 14, 2017

📌 Commit 2f33093 has been approved by alexcrichton

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2017
@kennytm
Copy link
Member

kennytm commented Dec 14, 2017

@bors rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Dec 15, 2017
@steveklabnik
Rollup merge of rust-lang#46705 - pornel:cargo-output, r=alexcrichton
180a6b2 
Help Cargo tolerate RUSTFLAGS="--print=native-static-libs"

Alternative to rust-lang/cargo#4807

Having this "error" message was a mistake, as it's firing at exactly wrong time when Cargo is trying to read the output of other print commands.
@steveklabnik steveklabnik mentioned this pull request Dec 15, 2017
Merged
bors added a commit that referenced this pull request Dec 15, 2017
@bors
Auto merge of #46745 - steveklabnik:rollup, r=steveklabnik
50f6c3e 
Rollup of 7 pull requests

- Successful merges: #46601, #46652, #46690, #46705, #46710, #46728, #46737
- Failed merges:
@bors bors merged commit 2f33093 into rust-lang:master Dec 15, 2017
@kornelski kornelski deleted the cargo-output branch December 15, 2017 22:33
@dwijnand dwijnand mentioned this pull request Sep 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kornelski @rust-highfive @arielb1 @alexcrichton @bors @kennytm