-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't warn about ignored files in cargo-fix #5770
Conversation
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #5762) made this pull request unmergeable. Please resolve the merge conflicts. |
Hmm, does this now also ignore untracked .rs source files? That would probably be against the spirit of the warning... |
Fixes #5771 |
I agree with @birkenfeld. IIRC, our idea was to warn people when cargo-fix would change files that were not under version control. So, I can see the reason why we should not concern ourselves with files that are explicitly ignored (in |
They're not being tracked, so no worries if we stomp over them!
8fe3534
to
6cdee67
Compare
r? @killercup @bors: delegate=killercup Updated to include untracked files! |
✌️ @killercup can now approve this pull request |
Thanks, Alex! LGTM @bors r+ |
📌 Commit 6cdee67 has been approved by |
Don't warn about ignored files in cargo-fix They're not being tracked, so no worries if we stomp over them!
☀️ Test successful - status-appveyor, status-travis |
Is this going to be affected by https://github.com/alexcrichton/git2-rs/issues/334, if not is this an alternative workaround for #5733? |
@Eh2406 I believe this is using a different API so it shouldn't need that fix |
Do we know when this will be out in nightly? Latest nightly's cargo is a week old. |
They're not being tracked, so no worries if we stomp over them!