Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI with Azure Pipelines #7139

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Set up CI with Azure Pipelines #7139

merged 1 commit into from
Jul 23, 2019

Conversation

alexcrichton
Copy link
Member

No description provided.

@rust-highfive
Copy link

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2019
@alexcrichton alexcrichton force-pushed the azure-pipelines branch 2 times, most recently from b287323 to 9974034 Compare July 15, 2019 21:21
@alexcrichton
Copy link
Member Author

While we don't have a burning need to migrate to Azure Pipelines now that it's been done in rust-lang/rust I think it'd also be good to do for Cargo. This also brings with it a number of benefits:

  • One system to configure all our platforms
  • More parallelism, especially for Windows

So largely a nice-to-have, but I wanted to iterate and see how bad it was to set up in the meantime. Note that I'm working on getting this configuration working, it'll likely need some massaging here and there.

@bors
Copy link
Collaborator

bors commented Jul 16, 2019

☔ The latest upstream changes (presumably #7140) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member Author

Ok so Windows has a bunch of failures that look like:

  3 - |error: the crate `test v0.1.0 (d:\a\1\s\target\cit\t1248\foo)` depends on crate `foo v0.1.0` multiple times with different names|
    + |error: the crate `test v0.1.0 (D:\a\1\s\target\cit\t1248\foo)` depends on crate `foo v0.1.0` multiple times with different names|

where basically we're asserting paths look like d:\... but they instead look like D:\.... I did what amounted to too much digging to figure out where these were coming from, and it turns out that Url::from_file_path will "canonicalize" to an uppercase drive letter. The env::current_dir() function will return d:\... but round-tripping that through Url will yield D:\..., causing the discrepancy. Fun!

@alexcrichton alexcrichton force-pushed the azure-pipelines branch 2 times, most recently from 289a10f to ce04a53 Compare July 16, 2019 16:59
@alexcrichton
Copy link
Member Author

More work is necessary to do normalization on the output of cargo vs what we wrote in tests, I'll try to work on that soon when I get a chance.

@alexcrichton alexcrichton force-pushed the azure-pipelines branch 18 times, most recently from 40bff46 to deef0f8 Compare July 18, 2019 16:19
@alexcrichton
Copy link
Member Author

@ehuss it does use the same account yes, and it does use the spare capacity. We'd like to change that over time though so it's shared with other rust-lang projects at 10 concurrency which is separate from rust-lang/rust, but we're still working with Azure to do that.

@ehuss
Copy link
Contributor

ehuss commented Jul 22, 2019

Let's see what happens!

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 22, 2019

📌 Commit 2107f9aa05c29742510896f1c8b6c79e472c6f9a has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2019
@bors
Copy link
Collaborator

bors commented Jul 22, 2019

⌛ Testing commit 2107f9aa05c29742510896f1c8b6c79e472c6f9a with merge 24ca5ccdf62a2e80b6d39ebd369afd89fbc76523...

@bors
Copy link
Collaborator

bors commented Jul 22, 2019

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 22, 2019
@ehuss
Copy link
Contributor

ehuss commented Jul 22, 2019

Not sure if the timeout was due to the github outage, or if there are some hooks that need to be configured?

@alexcrichton
Copy link
Member Author

Oh I'll need to reconfigure bors to listen for the right GitHub status check, I'll wait to merge before doing that

@alexcrichton alexcrichton mentioned this pull request Jul 23, 2019
Merged
@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Collaborator

bors commented Jul 23, 2019

📌 Commit c2354b9 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2019
@bors
Copy link
Collaborator

bors commented Jul 23, 2019

⌛ Testing commit c2354b9 with merge a2f5431...

bors added a commit that referenced this pull request Jul 23, 2019
@bors
Auto merge of #7139 - rust-lang:azure-pipelines, r=alexcrichton
a2f5431 
Set up CI with Azure Pipelines
@bors
Copy link
Collaborator

bors commented Jul 23, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing a2f5431 to master...

@bors bors merged commit c2354b9 into master Jul 23, 2019
@alexcrichton alexcrichton deleted the azure-pipelines branch July 23, 2019 17:22
@bors bors mentioned this pull request Jul 23, 2019
Merged
@ehuss ehuss mentioned this pull request Jul 23, 2019
Merged
bors added a commit to rust-lang/rust that referenced this pull request Jul 26, 2019
@bors
Auto merge of #62914 - ehuss:update-cargo, r=alexcrichton
1a56336 
Update cargo

11 commits in e3563dbdcd2e370bc4f11d080f739d82d25773fd..d0f828419d6ce6be21a90866964f58eb2c07cd56
2019-07-16 19:22:44 +0000 to 2019-07-23 21:58:59 +0000
- Remove include/exclude glob warning. (rust-lang/cargo#7170)
- Optimize lock file format for git merge conflicts (rust-lang/cargo#7070)
- Set up CI with Azure Pipelines (rust-lang/cargo#7139)
- Force clippy to run. (rust-lang/cargo#7157)
- Work around #61440 (rust-lang/cargo#7158)
- initial working version of cargo fix --clippy (rust-lang/cargo#7069)
- Optimize runtime of `#[cargo_test_macro]` (rust-lang/cargo#7146)
- Don't fail if we can't acquire readonly lock (rust-lang/cargo#7149)
- Add support for multiple --features options (rust-lang/cargo#7084)
- Fix a typo in an env var name (rust-lang/cargo#7145)
- Add a way to disable all nightly tests (rust-lang/cargo#7142)
@ehuss ehuss added this to the 1.38.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexcrichton @rust-highfive @bors @ehuss @nrc