Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving #[cfg(test)] modules into a separate files to save recompiling the std crate #344

Closed
3 tasks done
tesuji opened this issue Aug 13, 2020 · 3 comments
Closed
3 tasks done

Moving #[cfg(test)] modules into a separate files to save recompiling the std crate #344

tesuji opened this issue Aug 13, 2020 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@tesuji
Copy link

tesuji commented Aug 13, 2020 •
edited
Loading

Proposal

Moving #[cfg(test)] modules into a separate files to save recompiling the std crate
when only that test file changes.

core and src/lib* crate already did that.

Moving tests around will be a very big change.
It also makes it harder to blame specific code in tests.
I would like infra member to take care of it, through I could do it myself if wanted.

Relevant PR:

Mentors or Reviewers

If you have a reviewer or mentor in mind for this work, mention then
here. You can put your own name here if you are planning to mentor the
work.

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@tesuji tesuji added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Aug 13, 2020
@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Aug 13, 2020
@petrochenkov
Copy link

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Aug 13, 2020
@petrochenkov petrochenkov mentioned this issue Aug 19, 2020
Closed
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Aug 19, 2020
@tesuji
Copy link
Author

tesuji commented Aug 26, 2020

Is this proposal accepted?

@spastorino spastorino added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Aug 26, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Aug 26, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Aug 26, 2020
@tesuji tesuji mentioned this issue Aug 27, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 31, 2020
@bors
Auto merge of rust-lang#75979 - lzutao:seprate-tests, r=Mark-Simulacrum
45f638b 
Move `#[cfg(test)]` modules into separate files to save recompiling the `std` crate

Implements an accepted proposal: rust-lang/compiler-team#344

Some notes for reviewers:
* `mod tests` nested in `mod foo` in `mod bar`, I move `foo` to a new file, `tests` is a new file in foo: For example library/std/src/sys/sgx/abi/tls.rs
* `mod test` (not `mod tests`) also is moved.
* `mod benches` are moved.
* `mod tests` is placed before any `use` statements: The topic is discussed in https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Code.20Style.20process
* Some files in cloudabi was changed too. But I notice copyright banners in those files, should we ping cloudabi people?
* I formatted files after moving tests around. I think that may make it easier to review :p .
* Some files don't need `ignore-tidy-filelength` anymore.
@tesuji tesuji mentioned this issue Mar 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spastorino @petrochenkov @tesuji @rustbot