You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the old compiler successfully built a crate, but failed to build its tests, and the new compiler failed to build the main crate, that should be reported as a regression (and vice-versa as a fix).
But both failing to build the main crate and failure to build the tests currently result in a BuildFail status (TestFail only comes from failure to run the tests):
Noticed in rust-lang/rust#80953 (in that case, the new compiler failed the same way as the old one, but if the new compiler did have the regression, it wouldn't have been noticed due to this).
The text was updated successfully, but these errors were encountered:
If the old compiler successfully built a crate, but failed to build its tests, and the new compiler failed to build the main crate, that should be reported as a regression (and vice-versa as a fix).
But both failing to build the main crate and failure to build the tests currently result in a
BuildFail
status (TestFail
only comes from failure to run the tests):crater/src/runner/test.rs
Lines 230 to 280 in 674e4c2
Noticed in rust-lang/rust#80953 (in that case, the new compiler failed the same way as the old one, but if the new compiler did have the regression, it wouldn't have been noticed due to this).
The text was updated successfully, but these errors were encountered: