Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreaudio-sys 0.2.5 failed to build #853

Closed
mitchmindtree opened this issue Jun 25, 2020 · 8 comments
Closed

coreaudio-sys 0.2.5 failed to build #853

mitchmindtree opened this issue Jun 25, 2020 · 8 comments
Labels
C-build-failure Category: This is a crate that failed to build S-waiting-on-crate-author Status: This is a build failure that has to be fixed by the crate author, not the docs.rs team

Comments

@mitchmindtree
Copy link

Crate name:

coreaudio-sys 0.2.5

Build failure link:

https://docs.rs/crate/coreaudio-sys/0.2.5/builds/264503

Additional details:

The crate used to fail as expected when publishing previous versions, however with 0.2.5 I attempted to fix the Cargo.toml metadata to select the correct target for building coreaudio-sys docs for x86_64-apple-darwin. The crate seems to build successfully for the same target in our github action, but fails on docs.rs.

I've opened an issue at RustAudio/coreaudio-sys#40 with more details/thoughts. Any advice on how we might go about fixing the build would be greatly appreciated!

@mitchmindtree mitchmindtree added the C-build-failure Category: This is a crate that failed to build label Jun 25, 2020
@Nemo157
Copy link
Member

Nemo157 commented Jun 25, 2020

A big difference from your CI build is that docs.rs is always cross-compiling from linux, you are only able to control the target not the host. So there would need to be a way to get the required header files on the Ubuntu image used for the build.

@mitchmindtree
Copy link
Author

Ahh I see!

It looks like we might benefit from solving RustAudio/coreaudio-sys#38 and updating our docs-check action to cross-compile from Ubuntu to match the docs.rs approach.

Thanks for the tip!

@jyn514
Copy link
Member

jyn514 commented Jun 25, 2020

docs.rs is always cross-compiling from linux,

This would be good to document, a lot of our build failures have been coming from this.

@jyn514 jyn514 added the S-waiting-on-crate-author Status: This is a build failure that has to be fixed by the crate author, not the docs.rs team label Jul 4, 2020
@jyn514
Copy link
Member

jyn514 commented Apr 18, 2021

@mitchmindtree are you still planning to work on this?

@mitchmindtree
Copy link
Author

I have no plans related to this at the moment, though I believe it is still an issue for coreaudio-rs and coreaudio-sys. I do still have a WIP PR at coreaudio-sys which I'd be more than happy for someone to take over RustAudio/coreaudio-sys#38. I don't mind if you wish to close this due to inactivity. I'll leave a note at the PR recommending someone take over.

@mitchmindtree
Copy link
Author

@jyn514 one thing that might be useful is if you could link to the CI/script that docs.rs uses to cross-compile for macOS from Linux. This way we can check the coreaudio-sys CI matches, uses the same versions/SDK, etc.

@jyn514
Copy link
Member

jyn514 commented Apr 18, 2021

@mitchmindtree you can replicate it by running docs.rs itself locally: https://forge.rust-lang.org/docs-rs/add-dependencies.html#testing-the-image

There's also an unofficial script, but it's not tested: https://github.com/Nemo157/dotfiles/blob/master/bin/cargo-doc-like-docs.rs

@jyn514
Copy link
Member

jyn514 commented Jun 21, 2021

Closing due to inactivity; feel free to reopen if you're still having trouble and have time to debug things.

@jyn514 jyn514 closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build-failure Category: This is a crate that failed to build S-waiting-on-crate-author Status: This is a build failure that has to be fixed by the crate author, not the docs.rs team
Projects
None yet
Development

No branches or pull requests

3 participants