Applying diff with renamed file to Index ignores delta callback and removes old file from index

[aganzha]

How to reproduce:

• rename file in repository
• apply diff from index to workdir with delta callback returning false

Estimated behaviour: index remain unchanged. no changes staged.
Current behaviour: old file deleted from index.

use git2::{
    Repository, ApplyOptions, ApplyLocation
};

fn main() {

    // just rename 1 file in repositiry and run this.
    // old file will be removed from index.
    let repo = Repository::open("./")
        .expect("can't open repo");
    let git_diff = repo.diff_index_to_workdir(None, None)
        .expect("can't get diff");

    let mut options = ApplyOptions::new();
    options.hunk_callback(|odh| -> bool {
        false
    });
    options.delta_callback(|odd| -> bool {
        false
    });

    repo.apply(
        &git_diff,
        ApplyLocation::Index,
        Some(&mut options),
    ).expect("can't apply patch");
}

[extrawurst]

Probably best to post upstream in libgit2 repo (repro in rust is fine) as git2-rs is just bindings

[aganzha]

Thank You

[aganzha]

libgit2/libgit2#6643

[ehuss]

Thanks! We don't mirror or track libgit2 issues here, so I'm going to close this as it does look like an upstream issue. If it gets fixed, we'll pick the fix up in the next update.