Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic CLI fallback #600

Open
kornelski opened this issue Aug 2, 2020 · 2 comments
Open

Automatic CLI fallback #600

kornelski opened this issue Aug 2, 2020 · 2 comments

Comments

@kornelski
Copy link
Contributor

kornelski commented Aug 2, 2020

libgit2 is known for having issues with some authentication methods and SSH URLs. The common solution to this is to use git CLI as a fallback.

Currently every user of the git2 crate has to implement the fallback themselves. There are over 500 crates that use git2, so for users who need a better auth, it's a whack-a-mole of crates that aren't quite working.

I suggest adding the fallback to the git2 crate itself, so that all downstream users are automatically improved. The fallback could be controlled via env variable, so users who need the fallback could enable it once for all Rust crates.

@let4be
Copy link

let4be commented Jun 2, 2021

any update?...

@itsfarseen
Copy link

If anyone wants to take a crack at this, let's build a list of things to be done.

  • Make a list of cases git2 doesn't behave correctly.
  • Prioritize the list, discuss and decide which ones to implement immediately.
  • Make a list of workarounds employed by different users of this crate.
  • Discuss and decide which workaround to choose, make sure it doesn't break existing use cases.
  • Figure out which files/functions do we need to patch.
  • Code and run tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants