Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Automatically add regression labels to glacier tracked issues #767

Closed
wants to merge 1 commit into from

Conversation

mibac138
Copy link
Contributor

@mibac138 mibac138 commented Jun 7, 2021

Fixes #568

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't add this functionality.
The problem is that this will cause a lot of notifications, as mentioned in https://rust-lang.zulipchat.com/#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/adding.20labels.20to.20stable-to-stable.20regressions. And I don't think it makes much sense to label all the ICEs, which produces much work to wg-prioritization. Moreover relabeling is also unnecessary currently IMO. Looking at regression-from-stable-to-nightly and regression-from-stable-to-beta, some members triage them manually and add milestones, it should be enough.

@JohnTitor
Copy link
Member

But this PR has some unrelated refactoring, e.g. removing regex dependency. I'm happy to accept it.

@mibac138
Copy link
Contributor Author

mibac138 commented Jun 7, 2021

I didn't realize this would ping prioritization and add so much work for them. I agree that it shouldn't notify them on every ice added to glacier. Should #568 be closed then?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatically label beta/stable regression
2 participants