Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bors sometimes makes PRs haunted #205

Open
Noratrieb opened this issue Feb 25, 2024 · 0 comments
Open

bors sometimes makes PRs haunted #205

Noratrieb opened this issue Feb 25, 2024 · 0 comments

Comments

@Noratrieb
Copy link
Member

it happened here rust-lang/rust#117494

  • a different PR, compiler: clippy::complexity fixes rust#121523, started being tested
  • CI failed
  • the tree was closed after a retry and then tried a few times
  • meanwhile, our friend 117494 was being try built
  • after the tree was reopened, somehow 117494 started being shown as currently testing
  • the try build completed
  • probably because the "Mark job as successful" job doesn't run in try, bors thought that it hasn't completed
  • Several hours later, it was still marked as testing, blocking the queue
  • I did bors retry, throwing it out and unblocking the queue
  • I closed the PR anyways because I was afraid bors would just push to master after the try build
  • I reopened the PR and tried again
  • it was now also makes as testing, not trying!
  • I closed the PR
  • PR's haunted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant